php - Eloquent logic refactor -

-

today came legacy code. have function generates long runtimes , occurs timeout @ our partner. function checks reserved seats @ theatre instead of data , check empty seats runs query every single seat. (i think) generates huge runtime.

here correspondig code: 

public function printticketchaos(){          $input = input::all();          if( isset($input['date_id']) && !isset($input['reserve_id']) ){             $program_date = \model\programdate::find($input['date_id']);             if($input['piece'] > $program_date->available_capacity){                 //dd($input['piece'] . ' ??? ' . $program_date->available_capacity);                 return true;             }              $reserved_seats = session::get('reserved_seats');              if($reserved_seats != null && count($reserved_seats) > 0){                 foreach ($reserved_seats $row => $seats) {                     foreach ($seats $key => $seat) {                          $reserve = \model\reserve::whereforeigndateid($program_date->id)->wheretablename('programs')->wherehas('seats', function($query) use($row, $seat){ $query->whererow($row)->whereseat($seat); })->first();                          if($reserve != null){                             return true;                         }                         $oi = \model\orderitem::whereforeignid($program_date->id)->wheretablename('programs')->wherehas('order', function($query){ $query->wherestorno(0); })->wherehas('seats', function($query) use($row, $seat){ $query->whererow($row)->whereseat($seat); })->first();                         if($oi != null){                             return true;                         }                     }                 }             }         }           return false;     }

i think solution query seats , check empty ones in foreach. idea or think best way it?

the code uses laravel 4.2

thank aswers!

okay, made changes in query , logic aswell still slow hell. system uses 3rd party pdf generator create "ticket" costumer , "bad guy".


Comments

Post a Comment

Popular posts from this blog

Hatching array of circles in AutoCAD using c# -

-
i beginner in autocad plugins .i have created array of circle using following code. now, have hatch circles in array .how that??how hatch circles @ once? moreover, how can return hatch method , use hatch objects.sorry language.thanks in advance. [assembly: commandclass(typeof(beamsection.class1))] namespace beamsection { public class class1 { //class1 obj = new class1(); [commandmethod("beamatsupport")] public void addlightweightpolyline() { // current document , database document acdoc = application.documentmanager.mdiactivedocument; database accurdb = acdoc.database; promptpointresult ppr = acdoc.editor.getpoint("\nselect starting point "); var ucs = acdoc.editor.currentusercoordinatesystem; point3d startingpt = ppr.value.transformby(ucs); list<double> radius = new list<double>(); radius.add(0.5); ...
Read more

ios - UITEXTFIELD InputView Uipicker not working in swift -

-
hello trying pop uipickerview view programmatically when user clicks on textfield. have tried doesn't doing anything. isn't working. nothing happening when click textfield class userprofiletableviewcontroller: uitableviewcontroller,uitextfielddelegate,uipickerviewdelegate,uipickerviewdatasource { var itempicker: uipickerview! = uipickerview() @iboutlet weak var gendertxtfield: uitextfield! var gender = ["male","female"] override func viewdidload() { super.viewdidload() gendertxtfield.delegate = self itempicker!.delegate = self itempicker!.datasource = self itempicker!.backgroundcolor = uicolor.blackcolor() self.gendertxtfield.inputview = itempicker } func numberofcomponentsinpickerview(pickerview: uipickerview) -> int{ return 1 } // returns # of rows in each component.. func pickerview(pickerview: uipickerview, numberofrowsincomponent component:...
Read more